[Spring starter] Make sdk bean overridable and cache env calls #15132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
zeitlinger
reviewed
Oct 24, 2025
...lemetry/instrumentation/spring/autoconfigure/internal/properties/SpringConfigProperties.java
Outdated
Show resolved
Hide resolved
...lemetry/instrumentation/spring/autoconfigure/internal/properties/SpringConfigProperties.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Oct 27, 2025
| @Override | ||
| public String getString(String name) { | ||
| String normalizedName = ConfigUtil.normalizeEnvironmentVariableKey(name); | ||
| String value = environment.getProperty(normalizedName, String.class); |
There was a problem hiding this comment.
An alternative approach that could be considered would be to wrap the environment into a caching PropertyResolver. I presume that the sdk deliberately rereads these properties so they could be updated with opamp in the future. Idk whether this is something we should be concerned with.
There was a problem hiding this comment.
I presume that the sdk deliberately rereads these properties
no, it was not a deliberate decision as far as I know.
When I worked on the project, I assumed that properties would only be read at startup time.
I think it's hard to anticipate how OpAMP will be integrated, but we may simply flush the cache (from the caching PropertyResolver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15009
Add ability for users to customize AutoConfiguredOpenTelemetrySdk, and add cache for environment config lookups.